[Issue #736] pipeline execution of hash partitioned join (cont.) #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion stream worker
…end streaming support to post partition of joins
…end streaming support to post partition of joins
…age infos in PixelsPlanner
…dJoinStreamOperator
…ing storage infos in PixelsPlanner" This reverts commit 09bc92c.
bianhq
requested changes
Nov 8, 2024
...er/src/main/java/io/pixelsdb/pixels/planner/plan/physical/PartitionedJoinStreamOperator.java
Outdated
Show resolved
Hide resolved
...-worker-common/src/main/java/io/pixelsdb/pixels/worker/common/BasePartitionStreamWorker.java
Outdated
Show resolved
Hide resolved
...r-common/src/main/java/io/pixelsdb/pixels/worker/common/BasePartitionedJoinStreamWorker.java
Outdated
Show resolved
Hide resolved
...r-common/src/main/java/io/pixelsdb/pixels/worker/common/BasePartitionedJoinStreamWorker.java
Outdated
Show resolved
Hide resolved
...r-common/src/main/java/io/pixelsdb/pixels/worker/common/BasePartitionedJoinStreamWorker.java
Outdated
Show resolved
Hide resolved
...r-common/src/main/java/io/pixelsdb/pixels/worker/common/BasePartitionedJoinStreamWorker.java
Outdated
Show resolved
Hide resolved
...r-common/src/main/java/io/pixelsdb/pixels/worker/common/BasePartitionedJoinStreamWorker.java
Outdated
Show resolved
Hide resolved
...r-common/src/main/java/io/pixelsdb/pixels/worker/common/BasePartitionedJoinStreamWorker.java
Outdated
Show resolved
Hide resolved
...r-common/src/main/java/io/pixelsdb/pixels/worker/common/BasePartitionedJoinStreamWorker.java
Outdated
Show resolved
Hide resolved
huasiy
reviewed
Nov 8, 2024
...-turbo/pixels-invoker-vhive/src/main/java/io/pixelsdb/pixels/invoker/vhive/VhiveInvoker.java
Show resolved
Hide resolved
…end streaming support to post partition of joins
…end streaming support to post partition of joins
…age infos in PixelsPlanner
…dJoinStreamOperator
…ing storage infos in PixelsPlanner" This reverts commit 09bc92c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nationandregionare in the join query, some of their partitions will be empty. In legacy non-streaming mode, the next-level workers can simply write nothing to the intermediate file, and skip the join if the joiner hash table is empty. But in streaming mode, we still have to send an empty row group to next-level workers, and still have to listen on joiner ports even if its hash table is empty, to enforce the streaming protocol - otherwise, we cannot distinguish between empty intermediate data and worker failure.trinostartup process to get stuck. Its constructor should not be blocking.