Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove restriction on duplicate sarif tools #925

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

drdavella
Copy link
Member

This effectively reverts #742. It was based on an assumption that does not hold in a polyglot environment for tools that may scan each language separately (e.g. CodeQL).

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link
Contributor

@nahsra nahsra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving without understanding why this fence was put up in the first place.

@drdavella drdavella enabled auto-merge November 21, 2024 00:38
@drdavella drdavella added this pull request to the merge queue Nov 21, 2024
Merged via the queue into main with commit 7ebf129 Nov 21, 2024
14 checks passed
@drdavella drdavella deleted the remove-duplicate-tool-restriction branch November 21, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants