Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update threading docs info #78

Merged
merged 1 commit into from
Oct 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/core_codemods/with_threading_lock.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ class WithThreadingLock(SemgrepCodemod, NameResolutionMixin):
DESCRIPTION = (
"Replace deprecated usage of threading lock classes as context managers."
)
REVIEW_GUIDANCE = ReviewGuidance.MERGE_AFTER_CURSORY_REVIEW
REVIEW_GUIDANCE = ReviewGuidance.MERGE_WITHOUT_REVIEW
REFERENCES = [
{
"url": "https://pylint.pycqa.org/en/latest/user_guide/messages/warning/useless-with-lock.",
Expand Down
3 changes: 2 additions & 1 deletion src/scripts/generate_docs.py
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,8 @@ class DocMetadata:
guidance_explained="We believe that using the walrus operator is an improvement in terms of clarity and readability. However, this change is only compatible with codebases that support Python 3.8 and later, so it requires quick validation before merging.",
),
"bad-lock-with-statement": DocMetadata(
importance="Low", guidance_explained="TODO AFTER PR MERGE"
importance="Low",
guidance_explained="We believe this replacement is safe and should not result in any issues.",
),
}

Expand Down