Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove py3.9, use py3.12 #77

Merged
merged 4 commits into from
Oct 17, 2023
Merged

Remove py3.9, use py3.12 #77

merged 4 commits into from
Oct 17, 2023

Conversation

clavedeluna
Copy link
Contributor

@clavedeluna clavedeluna commented Oct 17, 2023

Overview

PY3.12 recently came out so we will use it and stop using 3.9

Description

  • just a couple of changes and fixes to get this to work
  • I did look to see if we have some obivous code that would benefit from match/case but surprisingly our number of else: statements is pretty small
  • need to update PR necessary checks before merging this

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #77 (50e664f) into main (8b93bae) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #77   +/-   ##
=======================================
  Coverage   96.22%   96.22%           
=======================================
  Files          46       46           
  Lines        1826     1826           
=======================================
  Hits         1757     1757           
  Misses         69       69           
Files Coverage Δ
src/codemodder/registry.py 93.65% <100.00%> (ø)

@clavedeluna clavedeluna marked this pull request as ready for review October 17, 2023 11:58
Copy link
Contributor

@andrecsilva andrecsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the dockerfile should also be updated with the new 3.12 image.

@@ -103,7 +103,7 @@ def match_codemods(
def load_registered_codemods() -> CodemodRegistry:
registry = CodemodRegistry()
logger.debug("loading registered codemod collections")
for entry_point in entry_points()["codemods"]:
for entry_point in entry_points().select(group="codemods"):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@clavedeluna clavedeluna merged commit 8573a09 into main Oct 17, 2023
8 checks passed
@clavedeluna clavedeluna deleted the py12 branch October 17, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants