Jinja autoescape #50
Merged
Jinja autoescape #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clavedeluna
force-pushed
the
jinja-autoescape
branch
from
a5b398b to
9c717d7
Compare
clavedeluna
force-pushed
the
jinja-autoescape
branch
2 times, most recently
from
b85c36f to
f909c5a
Compare
clavedeluna
force-pushed
the
jinja-autoescape
branch
from
f909c5a to
63e6a63
Compare
drdavella
requested changes
Sep 27, 2023
| from jinja2 import Environment | ||
|
|
||
| - env = Environment() | ||
| - env = Environment(autoescape=False, loader=some-loader) |
There was a problem hiding this comment.
Minor thing but the - here and below is not valid Python syntax.
| jinja2.Environment(...) | ||
| - pattern: | | ||
| jinja2.Environment(..., autoescape=False, ...) | ||
| - pattern-not: | |
There was a problem hiding this comment.
Wouldn't this pattern-not by itself be sufficient instead of enumerating the other cases above?
There was a problem hiding this comment.
oh hmm good point let me check if tests pass with that
| else: | ||
| new = arg | ||
| new_args.append(new) | ||
|
|
||
| if add_if_missing and not arg_added: | ||
| new = cst.Arg( |
There was a problem hiding this comment.
Just a small thing but it seems like this Arg creation could be factored out into another method.
There was a problem hiding this comment.
ah yes, thought about that and forgot, will do!
| return """ | ||
| rules: | ||
| - patterns: | ||
| - pattern-either: |
There was a problem hiding this comment.
See comment below but I think this might be redundant with the pattern-not.
src/core_codemods/docs/pixee_python_enable-jinja2-autoescape.md
Outdated
Show resolved
Hide resolved
src/core_codemods/docs/pixee_python_enable-jinja2-autoescape.md
Outdated
Show resolved
Hide resolved
src/core_codemods/docs/pixee_python_enable-jinja2-autoescape.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Dan D'Avella <[email protected]>
clavedeluna
force-pushed
the
jinja-autoescape
branch
from
55d183e to
24a768a
Compare
drdavella
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add a codemod that checks if jinja2.Environment enables autoescape
Description
autoescape, a jinja2 setting to guard against XSS attacks, is disabled by default (and can explicitly be disabled)select_autoescapefunction (see bug report here), this codemod does not detect if autoescape is assigned to a callable, such asEnvironment(autoescape=select_autoescape()). this is the recommended way in the docs. We will cover that later.