Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add detection and processing for external Semgrep SARIF files #459

Merged
merged 3 commits into from
Apr 11, 2024
Merged

Add detection and processing for external Semgrep SARIF files #459

merged 3 commits into from
Apr 11, 2024

Conversation

drdavella
Copy link
Member

Overview

Add detection and processing for external Semgrep SARIF files

Description

  • Adds the ability for codemodder to detect Semgrep SARIF files provided with the --sarif flag
  • Adds a Semgrep SARIF detector that can be used to write codemods that respond to external Semgrep SARIFs

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@pixeebot pixeebot bot mentioned this pull request Apr 11, 2024
Closed
clavedeluna
clavedeluna approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@clavedeluna clavedeluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expected to see an integration test with --sarif flag but maybe that's coming later.

@drdavella drdavella added this pull request to the merge queue Apr 11, 2024
Merged via the queue into main with commit 66b796d Apr 11, 2024
13 checks passed
@drdavella drdavella deleted the parse-semgrep-sarif branch April 11, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clavedeluna clavedeluna clavedeluna approved these changes

@andrecsilva andrecsilva Awaiting requested review from andrecsilva andrecsilva is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drdavella @clavedeluna