Support sonar hotspots and secure-random sonar hotspot rule #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clavedeluna
force-pushed
the
secure-sonar
branch
from
a741c04 to
8d8952d
Compare
|
clavedeluna
changed the title
drdavella
approved these changes
Apr 3, 2024
| context.tool_result_files_map.get("sonar", []) | ||
| ) | ||
| return self._lazy_cache | ||
|
|
||
|
|
||
| def process_sonar_findings(sonar_json_files: list[str]) -> SonarResultSet: |
There was a problem hiding this comment.
We could probably just use @functools.cache here and get rid of the _lazy_cache on the class?
There was a problem hiding this comment.
I swear I recall there was a reason this was written as is, I think @andrecsilva wrote it originally? because we also posed using @functools.cache at that time
There was a problem hiding this comment.
going to merge so I can use this PR to add more sonar codemods, but can come back to this if needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add support for sonar hotspots and the first sonar hotspot, secure-random
Description
Closes #376