Correct node position for FuncDef nodes and fix sonar codemods

[clavedeluna]

Overview

Add custom node_position for libcst.FuncDef nodes to support codemods that change code at function level

Description

• By default, libcst calculates all node start/end position. For simple nodes that span one line, the start and end line are the same. However, function def nodes have an end line and col position that belongs to the last line of the function, so:

# pos starts at `def` below
def func(arg):
     print(something) # pos ends here

However, for many codemods we really just care about matching the first line of the function def. So I've implemented this instead

# pos starts at `def` below
def func(arg):# pos ends here
     print(something) 

so the end position is the text length of the def ... line but index 0.

This now allows us to add include/exclude and results filtering to these codemods

Additional Details

• I also decided to json-ify sonar_issues.json.
• was able to dedupe code
• future work includes handling other nodes like class def

Closes #413

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[andrecsilva]

I'd rater have a general solution instead making one for every node type. I suggest changing either includes/excludes match or node_is_selected to match match any node that begins on a given line.

[clavedeluna]

I'm not sure I agree with a more general solution like that. In that case, why do we care about start/end columns at all right now? Is there not a reason why we do column matching in match_location nearby code? If there is, then that more general solution of just matching start line doesn't make much sense.

[andrecsilva]

Since discussions about matching nodes are pending, I think this is ok for a temporary solution.