Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add safeguards for constant subprocess commands #420

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

drdavella
Copy link
Member

Overview

Prevent false positives when adding hardening for subprocess commands

Description

Copy link
Contributor

@clavedeluna clavedeluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. It's a bit weird that the existing unit tests now have this "cmd" which isn't defined in the code snippet of the test. Do you think it makes sense to define it with an appropriate cmd value (argument passed from a func?)
  2. If cmd as a func arg isn't a good simple case for ^, could you add a test case for def func(cmd): subprocess.run(cmd....

@drdavella drdavella force-pushed the process-sandbox-exclude-hardcoded branch from f0db641 to d3dec3d Compare April 2, 2024 13:57
@drdavella drdavella requested a review from clavedeluna April 2, 2024 13:57
Copy link

sonarqubecloud bot commented Apr 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@drdavella drdavella added this pull request to the merge queue Apr 2, 2024
Merged via the queue into main with commit c6b96a8 Apr 2, 2024
12 checks passed
@drdavella drdavella deleted the process-sandbox-exclude-hardcoded branch April 2, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not apply sandbox-process-creation when arguments are literals
2 participants