Hardening suggestions for codemodder-python / pydantic-codetf #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pixeebot[bot]](https://avatars.githubusercontent.com/in/193111?s=60&v=4){kind=small}
| @@ -7,5 +7,5 @@ | |||
| @pytest.fixture(scope="module") | |||
| def codetf_schema(): | |||
| schema_path = "https://raw.githubusercontent.com/pixee/codemodder-specs/main/codetf.schema.json" | |||
| response = requests.get(schema_path) | |||
| response = requests.get(schema_path, timeout=60) | |||
There was a problem hiding this comment.
Add timeout to requests call
| @@ -176,8 +177,7 @@ def test_file_rewritten(self, codetf_schema): | |||
| self.check_code_before() | |||
| self.check_dependencies_before() | |||
|
|
|||
There was a problem hiding this comment.
Replaces subprocess.{func} with more secure safe_command library functions.
| @@ -191,8 +191,7 @@ def test_file_rewritten(self, codetf_schema): | |||
|
|
|||
| def _run_idempotency_chec(self, command): | |||
| # idempotency test, run it again and assert no files changed | |||
| completed_process = subprocess.run( | |||
| command, | |||
| completed_process = safe_command.run(subprocess.run, command, | |||
There was a problem hiding this comment.
Replaces subprocess.{func} with more secure safe_command library functions.
pyproject.toml
Outdated
| @@ -24,6 +24,7 @@ dependencies = [ | |||
| "tomlkit~=0.12.0", | |||
| "wrapt~=1.16.0", | |||
| "chardet~=5.2.0", | |||
| "security==1.2.1", | |||
There was a problem hiding this comment.
This library holds security tools for protecting Python API calls.
License: MIT ✅ Open Source ✅ More facts
drdavella
force-pushed
the
pydantic-codetf
branch
from
8c67680 to
1c925ae
Compare
drdavella
force-pushed
the
pixeebot/pydantic-codetf
branch
from
7d0bad7 to
8d8e8ee
Compare
|
drdavella
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've reviewed the recently opened PR (357 - Use Pydantic to generate and validate CodeTF data models) and have identified some area(s) that could benefit from additional hardening measures.
These changes should help prevent potential security vulnerabilities and improve overall code quality.
Thank you for your consideration!
docs | feedback
Powered by: pixeebot