Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize Sonar paths to base directory path #345

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Normalize Sonar paths to base directory path #345

merged 1 commit into from
Mar 8, 2024

Conversation

drdavella
Copy link
Member

@drdavella drdavella commented Mar 8, 2024 •
edited
Loading

Overview

Normalize paths relative to the given directory path for Sonar codemod findings

Description

  • This is a little bit subtle but we need the paths to be filtered relative to the given directory path
  • This required updating some tests and example data given the way we invoke the integration tests

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@drdavella drdavella enabled auto-merge March 8, 2024 19:15
@drdavella drdavella added this pull request to the merge queue Mar 8, 2024
Merged via the queue into main with commit c7a729a Mar 8, 2024
12 checks passed
@drdavella drdavella deleted the normalize-sonar-paths branch March 8, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrecsilva andrecsilva andrecsilva approved these changes

@clavedeluna clavedeluna Awaiting requested review from clavedeluna clavedeluna is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drdavella @andrecsilva