Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly configure SonarCloud exclusions #331

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Correctly configure SonarCloud exclusions #331

merged 1 commit into from
Mar 8, 2024

Conversation

clavedeluna
Copy link
Contributor

@clavedeluna clavedeluna commented Mar 5, 2024

Overview

We couldn't figure out why SonarCloud was not ignoring tests/samples... turns out it was the wrong file name!

Description

I know this works because I pushed a temp commit with a new addition to tests/samples and sonarcloud correctly ignored it. That commit isn't here anymore of course.

Closes #271

@clavedeluna clavedeluna force-pushed the sonar-excl branch 5 times, most recently from 800338e to eca2453 Compare March 7, 2024 12:04
@clavedeluna clavedeluna changed the title testing sonar exclusions Correctly configure SonarCloud exclusions Mar 7, 2024
@clavedeluna clavedeluna marked this pull request as ready for review March 7, 2024 12:06
Copy link

sonarqubecloud bot commented Mar 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@drdavella drdavella added this pull request to the merge queue Mar 8, 2024
Merged via the queue into main with commit 1b43f0b Mar 8, 2024
11 checks passed
@drdavella drdavella deleted the sonar-excl branch March 8, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure SonarCloud to ignore our test code
3 participants