Django models __str__ codemod
#302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ) | ||
|
|
||
|
|
||
| parser = etree.XMLParser() # Noncompliant |
Check failure
Code scanning / SonarCloud
XML parsers should not be vulnerable to XXE attacks
clavedeluna
force-pushed
the
django-str
branch
3 times, most recently
from
ce33072 to
b1d623f
Compare
andrecsilva
approved these changes
Feb 27, 2024
src/core_codemods/docs/pixee_python_django-model-without-dunder-str.md
Outdated
Show resolved
Hide resolved
drdavella
requested changes
Feb 27, 2024
src/core_codemods/docs/pixee_python_django-model-without-dunder-str.md
Outdated
Show resolved
Hide resolved
src/core_codemods/docs/pixee_python_django-model-without-dunder-str.md
Outdated
Show resolved
Hide resolved
src/core_codemods/docs/pixee_python_django-model-without-dunder-str.md
Outdated
Show resolved
Hide resolved
src/core_codemods/docs/pixee_python_django-model-without-dunder-str.md
Outdated
Show resolved
Hide resolved
|
|
||
| DjangoModelWithoutDunderStr = CoreCodemod( | ||
| metadata=Metadata( | ||
| name="django-model-without-dunder-str", |
There was a problem hiding this comment.
Not a huge deal but I feel like we're sometimes inconsistent as to whether a codemod is phrased in terms of a problem or a fix. I think we should prefer names in terms of fixes add-django-model-dunder-str but maybe we can just take it as a suggestion going forward.
clavedeluna
force-pushed
the
django-str
branch
from
67dbff3 to
b75037a
Compare
clavedeluna
force-pushed
the
django-str
branch
from
b75037a to
a3c2286
Compare
clavedeluna
force-pushed
the
django-str
branch
from
a3c2286 to
c5b5536
Compare
Co-authored-by: Dan D'Avella <[email protected]>
clavedeluna
force-pushed
the
django-str
branch
from
c5b5536 to
f82f43d
Compare
|
drdavella
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Codemod that will add a cookie-cutter
__str__method to any django model class that did not implement itDescription
Additional Details
Closes #287