Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce SUMMARY field for codemod; add to codetf2 output #30

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Enforce SUMMARY field for codemod; add to codetf2 output #30

merged 1 commit into from
Sep 11, 2023

Conversation

drdavella
Copy link
Member

Overview

Enforce SUMMARY field and add to codetf2 output

Description

  • CodeTF2 expects every result to have a description and summary field
  • We need to enforce this on both the simple API and internally
  • I'm not really happy with the current state of this. We need to revisit the design of these classes and the metadata fields. But I need this change in order to make progress with orchestrator work

ryandens
ryandens approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@ryandens ryandens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@drdavella drdavella merged commit 815fc04 into main Sep 11, 2023
6 checks passed
@drdavella drdavella deleted the ensure-summary-and-description branch September 11, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryandens ryandens ryandens approved these changes

@clavedeluna clavedeluna Awaiting requested review from clavedeluna clavedeluna is a code owner

@andrecsilva andrecsilva Awaiting requested review from andrecsilva andrecsilva is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drdavella @ryandens