Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pylint with ruff #277

Merged
merged 5 commits into from
Feb 19, 2024
Merged

Replace pylint with ruff #277

merged 5 commits into from
Feb 19, 2024

Conversation

clavedeluna
Copy link
Contributor

@clavedeluna clavedeluna commented Feb 19, 2024

Overview

ruff is a linter similar to pylint, but it's faster so we're going to favor using it

Description

  • To do this switch, I removed everything pylint related and did some very small noqa changes to align with ruff since it warned us about some things that we actually had disabled in pylintrc
  • FYII: inline ignore is done with # noqa: id while top-of-file is done with # ruff: noqa: id
  • Now ruff will run locally in your pre-commit (yay!) as well as in CI under the pre-commit step, instead of as a separate linting step.
  • I didn't do any deep dive to compare pylint and ruff so it's possible we may lose some interesting pylint checks that ruff doesn't have.

Additional Details

  • I can go a step further and actually replaceblack with ruff format. Check out the difference by running ruff format src tests integration_tests --exclude tests/samples/. It's minor differences.

Closes #276

@clavedeluna clavedeluna marked this pull request as ready for review February 19, 2024 13:48
Makefile Outdated Show resolved Hide resolved
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@clavedeluna clavedeluna added this pull request to the merge queue Feb 19, 2024
Merged via the queue into main with commit 8d6a03d Feb 19, 2024
11 checks passed
@clavedeluna clavedeluna deleted the ruff branch February 19, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use ruff instead of pylint
3 participants