Fix CodemodCollection API #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
clavedeluna
approved these changes
Feb 19, 2024
andrecsilva
approved these changes
Feb 19, 2024
drdavella
commented
Feb 19, 2024
| @@ -3,7 +3,7 @@ | |||
| from core_codemods.lazy_logging import LazyLogging | |||
|
|
|||
| logging_funcs = {"debug", "info", "warning", "warn", "error", "critical"} | |||
| each_func = pytest.mark.parametrize("func", logging_funcs) | |||
| each_func = pytest.mark.parametrize("func", sorted(logging_funcs)) | |||
There was a problem hiding this comment.
@clavedeluna this would be a good codemod, although we currently ignore test directories by default. I'd like to update that logic, though, so that the ignored directories are codemod-dependent.
There was a problem hiding this comment.
sorry which part exactly do you suggest as a codemod? sorting part?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Remove unused
CodemodCollectionattributesDescription
pytest-xdistlocally