Hardening suggestions for codemodder-python / dep-hashes #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pixeebot[bot]](https://avatars.githubusercontent.com/in/193111?s=60&v=4){kind=small}
pixeebot
bot
requested review from
drdavella,
andrecsilva and
clavedeluna
as code owners
src/codemodder/scripts/get_hashes.py
Outdated
|
|
||
|
|
||
| def get_package_hashes(package_name: str, version: str) -> list[str]: | ||
| """ | ||
| Fetch the SHA256 hashes for a given package version from PyPI. | ||
| """ | ||
| url = f"https://pypi.org/pypi/{package_name}/{version}/json" | ||
| response = requests.get(url) |
There was a problem hiding this comment.
Add timeout to requests call
| @@ -35,8 +35,7 @@ def main(): | |||
| continue | |||
|
|
|||
| package_name, version = arg.split("==", 1) | |||
| hashes = get_package_hashes(package_name, version) | |||
There was a problem hiding this comment.
Replaces multiple expressions involving if operator with 'walrus' operator.
|
@clavedeluna I'd like to drop the commit that adds the |
drdavella
force-pushed
the
pixeebot/dep-hashes
branch
from
694ef51 to
0d0931e
Compare
|
drdavella
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've reviewed the recently opened PR (273 - Requirements.txt writer adds hashes and a way to remember to update codemodder deps) and have identified some area(s) that could benefit from additional hardening measures.
These changes should help prevent potential security vulnerabilities and improve overall code quality.
Thank you for your consideration!
docs | feedback
Powered by: pixeebot