new jwt decode verify codemod #27
Conversation
|
@drdavella This is as ready as I can get it. I'm hoping the pipeline will pass. You can take it over while I'm out for 2 weeks (which would be good because then we can add this codemod to docs.pixee) or wait for me to come back and cleanup whatever minor thing is there. |
| @@ -31,7 +31,7 @@ jobs: | |||
| - name: Install Dependencies | |||
| run: pip install -r requirements/lint.txt | |||
| - name: Black Format Check | |||
| run: black --check . | |||
| run: black --check . --exclude samples/ | |||
There was a problem hiding this comment.
I think this and the corresponding pre-commit-hook update is the right call. There will be other instances when we want to test multiline and similar things and we don't want black to format it if our integration tests are expecting non-formatted code.
There was a problem hiding this comment.
This change ended up not being needed for my PR but it still seems useful.
clavedeluna
force-pushed
the
jwt-verify
branch
from
2bb3774 to
be39158
Compare
clavedeluna
force-pushed
the
jwt-verify
branch
from
c228dad to
63394e2
Compare
Codecov Report
@@ Coverage Diff @@
## main #27 +/- ##
==========================================
+ Coverage 95.78% 95.88% +0.10%
==========================================
Files 38 39 +1
Lines 1446 1484 +38
==========================================
+ Hits 1385 1423 +38
Misses 61 61
|
clavedeluna
force-pushed
the
jwt-verify
branch
2 times, most recently
from
fd7f8ce to
896cabb
Compare
Overview
Add a codemod that will check either the
verify(soon to be deprecated) flag to jwt.decode and/or the multipleverify_*kwargs in theoptionsparamDescription
verify=True, but foroptions={...verify...}I had to write some codemod-specific code. Maybe it can be generalized later on.options, a mixture of verify flag and options, etc.Additional Details