Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Honor annotations in subprocess-shell-false #259

Merged
merged 6 commits into from
Feb 13, 2024
Merged

Honor annotations in subprocess-shell-false #259

merged 6 commits into from
Feb 13, 2024

Conversation

drdavella
Copy link
Member

@drdavella drdavella commented Feb 13, 2024 •
edited
Loading

Overview

subprocess-shell-false should not modify code that is explicitly annotated as safe

Details

  • In certain cases it is perfectly valid to use shell=True in subprocess calls
  • In such cases where there is an explicit annotation, we should honor it and not make this change

@drdavella drdavella linked an issue Feb 13, 2024 that may be closed by this pull request
subprocess-shell-false should honor # noqa: S602 #249
Closed
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@drdavella drdavella marked this pull request as ready for review February 13, 2024 16:52
@drdavella drdavella added this pull request to the merge queue Feb 13, 2024
Merged via the queue into main with commit 464d9c9 Feb 13, 2024
12 checks passed
@drdavella drdavella deleted the 249-subprocess-shell-false-should-honor-noqa-s602 branch February 13, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clavedeluna clavedeluna clavedeluna approved these changes

@andrecsilva andrecsilva andrecsilva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

subprocess-shell-false should honor # noqa: S602
3 participants
@drdavella @andrecsilva @clavedeluna