New way to define a SonarCodemod and filter_by_result behavior change
#226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrecsilva
force-pushed
the
detector_and_sonar
branch
from
9afb1ed to
6ff560c
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #226 +/- ##
==========================================
+ Coverage 96.53% 96.55% +0.02%
==========================================
Files 101 101
Lines 4304 4301 -3
==========================================
- Hits 4155 4153 -2
+ Misses 149 148 -1
|
drdavella
approved these changes
Jan 29, 2024
| rules: list[str], | ||
| transformer: BaseTransformerPipeline | None = None, | ||
| new_references: list[Reference] | None = None, | ||
| ): # pylint: disable=too-many-arguments |
There was a problem hiding this comment.
Not for this PR but I think we should just reconfigure or disable this pylint rule globally.
clavedeluna
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
filter_by_resultandnode_is_selectedwill now be vacuously true if the detector isNoneSonarCodemodfrom a givenCoreCodemodsonar_numpy_nan_equalityandnumpy_nan_equality