Fix path inclusion behavior #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #224 +/- ##
=======================================
Coverage 96.47% 96.47%
=======================================
Files 98 98
Lines 4196 4197 +1
=======================================
+ Hits 4048 4049 +1
Misses 148 148
|
andrecsilva
approved these changes
Jan 26, 2024
clavedeluna
reviewed
Jan 26, 2024
| @@ -42,7 +42,7 @@ def test_all_py_files_match(self, dir_structure): | |||
|
|
|||
| def test_match_excluded(self, dir_structure): | |||
| expected = ["empty_for_testing.py", "insecure_random.py"] | |||
| files = match_files(dir_structure, ["**/tests/**", "*request.py"]) | |||
There was a problem hiding this comment.
would it make sense to keep one test with **/tests... ?
There was a problem hiding this comment.
Possibly but with the new behavior this isn't a valid match anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix path inclusion behavior
Description
--path-include