-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
harden-pyyaml codemod now also handles inheritance #205
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #205 +/- ##
==========================================
- Coverage 96.37% 96.37% -0.01%
==========================================
Files 86 86
Lines 3942 3968 +26
==========================================
+ Hits 3799 3824 +25
- Misses 143 144 +1
|
8fe3b39
to
f1a9f37
Compare
733ba9b
to
a2d2c8b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but one more suggestion for simplification/clarity.
a2d2c8b
to
a23f423
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just need to fix the pylint failure.
a23f423
to
65b4a41
Compare
65b4a41
to
970725a
Compare
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 1 New issue |
Overview
Update harden-pyyaml codemod to handle cases when a custom class inherits an unsafe loader class