New codemod to remove global lines at module level
#194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clavedeluna
force-pushed
the
global-mod-codemod
branch
from
16d85c7 to
53b844f
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #194 +/- ##
==========================================
- Coverage 96.38% 96.35% -0.04%
==========================================
Files 84 85 +1
Lines 3898 3918 +20
==========================================
+ Hits 3757 3775 +18
- Misses 141 143 +2
|
andrecsilva
requested changes
Jan 2, 2024
drdavella
requested changes
Jan 2, 2024
|
|
||
| class RemoveModuleGlobal(BaseCodemod, NameResolutionMixin): | ||
| NAME = "remove-module-global" | ||
| SUMMARY = "Remove Module-level Global Call" |
There was a problem hiding this comment.
Suggested change
| SUMMARY = "Remove Module-level Global Call" | |
| SUMMARY = "Remove Module-level `global` Keyword" |
clavedeluna
force-pushed
the
global-mod-codemod
branch
from
53b844f to
d38f381
Compare
drdavella
approved these changes
Jan 2, 2024
andrecsilva
approved these changes
Jan 3, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
clavedeluna
force-pushed
the
global-mod-codemod
branch
from
96223e3 to
1e0885c
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
A codemod that removes a line that uses
globalkeyword at the module levelAdditional Details
globalkeyword line within non-global scopes if a user missed them