Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added newline inference when adding dependencies in setup.py #190

Merged
merged 4 commits into from
Jan 3, 2024

Conversation

andrecsilva
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (efc0926) 96.35% compared to head (f3e42b3) 96.36%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #190      +/-   ##
==========================================
+ Coverage   96.35%   96.36%   +0.01%     
==========================================
  Files          82       82              
  Lines        3836     3850      +14     
==========================================
+ Hits         3696     3710      +14     
  Misses        140      140              
Files Coverage Δ
...odemodder/dependency_management/setup_py_writer.py 100.00% <100.00%> (ø)

@andrecsilva andrecsilva marked this pull request as ready for review December 22, 2023 10:17
Copy link
Member

@drdavella drdavella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice. I have a relatively nitpicky but substantive comment about commas.

src/codemodder/dependency_management/setup_py_writer.py Outdated Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Jan 2, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
2.5% Duplication on New Code

See analysis details on SonarCloud

@andrecsilva andrecsilva requested a review from drdavella January 2, 2024 16:37
@andrecsilva andrecsilva added this pull request to the merge queue Jan 3, 2024
Merged via the queue into main with commit 43145a6 Jan 3, 2024
14 checks passed
@andrecsilva andrecsilva deleted the setup-py-newlines branch January 3, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants