Added literal-or-new-object-identity codemod #186
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #186 +/- ##
==========================================
+ Coverage 96.25% 96.28% +0.03%
==========================================
Files 81 82 +1
Lines 3795 3826 +31
==========================================
+ Hits 3653 3684 +31
Misses 142 142
|
src/core_codemods/docs/pixee_python_literal-or-new-object-identity.md
Outdated
Show resolved
Hide resolved
| def leave_Comparison( | ||
| self, original_node: cst.Comparison, updated_node: cst.Comparison | ||
| ) -> cst.BaseExpression: | ||
| if self.filter_by_path_includes_or_excludes(self.node_position(original_node)): |
There was a problem hiding this comment.
I realized I've forgotten this filter in many of my own recent codemods so I'll need to go back and make updates.
There was a problem hiding this comment.
Another reason to have another look at the API. This should be automated in these simple cases.
| case cst.Comparison( | ||
| left=left, comparisons=[cst.ComparisonTarget() as target] | ||
| ): | ||
| if isinstance(target.operator, cst.Is | cst.IsNot): |
There was a problem hiding this comment.
Might be ever so slightly cleaner if you match here? But possibly I'm just obsessed with match right now.
There was a problem hiding this comment.
Not really, I'm not using the operator in any place. Using match would add an extra indentation which is why I avoid in those simple cases.
|
One additional comment but Sonar calls this out as a non-compliant example as well: mylist = [] # mylist is assigned a new object
param is mylist # Noncompliant: always FalseI know it's harder for us to do constant propagation without semgrep but we might want to add a ticket for this. |
|
I'll do this in a future PR. We kinda have the solution to that already but I need to do some testing here. |
Overview
Added a new codemod that replaces
isandis notcomparisons with literals and new objects with==