Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codemod for numpy NaN equality bug #156

Merged
merged 4 commits into from
Dec 1, 2023
Merged

Codemod for numpy NaN equality bug #156

merged 4 commits into from
Dec 1, 2023

Conversation

andrecsilva
Copy link
Contributor

Overview

This codemod will change any equality to numpy.nan using == to use numpy.isnan() instead.

@codecov Codecov
Copy link

codecov bot commented Dec 1, 2023 •
edited
Loading

Codecov Report

Merging #156 (85ed815) into main (575ed79) will decrease coverage by 0.04%.
Report is 9 commits behind head on main.
The diff coverage is 93.97%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #156      +/-   ##
==========================================
- Coverage   96.43%   96.40%   -0.04%     
==========================================
  Files          74       75       +1     
  Lines        3306     3389      +83     
==========================================
+ Hits         3188     3267      +79     
- Misses        118      122       +4
Files Coverage Δ
src/core_codemods/__init__.py 100.00% <100.00%> (ø)
src/core_codemods/numpy_nan_equality.py 97.05% <97.05%> (ø)
src/codemodder/codemods/utils_mixin.py 92.27% <78.57%> (-0.48%) ⬇️

@andrecsilva andrecsilva marked this pull request as ready for review December 1, 2023 14:16
drdavella
drdavella approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@drdavella drdavella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another very nice codemod overall. Just some minor comments.

src/core_codemods/docs/pixee_python_numpy-nan-equality.md Outdated Show resolved Hide resolved
tests/codemods/test_numpy_nan_equality.py Show resolved Hide resolved
src/core_codemods/numpy_nan_equality.py Outdated Show resolved Hide resolved
@andrecsilva andrecsilva added this pull request to the merge queue Dec 1, 2023
Merged via the queue into main with commit 1a9941c Dec 1, 2023
13 checks passed
@andrecsilva andrecsilva deleted the np-nan-equality branch December 1, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drdavella drdavella drdavella approved these changes

@clavedeluna clavedeluna Awaiting requested review from clavedeluna clavedeluna is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrecsilva @drdavella