-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup py writer #152
Setup py writer #152
Conversation
4f7c838
to
cebdcba
Compare
@drdavella I've addressed all your comments from previouis PR #150 (comment) in this PR The only one that isn't as clean is refactoring the Change list. Since each writer has a tiny difference in how we get the line number. If you have a better idea lmk. |
e7efe0c
to
9dfe421
Compare
@clavedeluna would it be possible to pass the line number as a parameter to a factored out method? If so I think it's a worthwhile change because I really want to avoid having to make updates to this in multiple places. |
b5e39c8
to
c9cbc0a
Compare
c9cbc0a
to
a5dd3b7
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #152 +/- ##
==========================================
+ Coverage 96.43% 96.47% +0.04%
==========================================
Files 74 74
Lines 3306 3351 +45
==========================================
+ Hits 3188 3233 +45
Misses 118 118
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff 👍
Overview
Integrate the setup.py writer to run and refactor
Description
Work we still need: