path_to_root should not include original node

pixee · Mar 13, 2024 · e6f08fe · e6f08fe
1 parent 7f5d2ca
commit e6f08fe
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/codemodder/codemods/utils_mixin.py b/src/codemodder/codemods/utils_mixin.py
@@ -449,10 +449,10 @@ def find_immediate_class_def(self, node: cst.CSTNode) -> Optional[cst.ClassDef]:
 
     def path_to_root(self, node: cst.CSTNode) -> list[cst.CSTNode]:
         """
-        Returns node's path to root. Includes self.
+        Returns node's path to `node` (excludes `node`).
         """
         path = []
-        maybe_parent = node
+        maybe_parent = self.get_parent(node)
         while maybe_parent:
             path.append(maybe_parent)
             maybe_parent = self.get_parent(maybe_parent)

diff --git a/tests/test_ancestorpatterns_mixin.py b/tests/test_ancestorpatterns_mixin.py
@@ -46,7 +46,7 @@ def transform_module_impl(self, tree: cst.Module) -> cst.Module:
                 node = stmt.body[0]
 
                 path = self.path_to_root(node)
-                assert len(path) == 3
+                assert len(path) == 2
                 return tree
 
         input_code = dedent(