use abstract

src/codemodder/context.py

@@ -41,7 +41,7 @@ def __init__(
         verbose: bool,
         registry: CodemodRegistry,
         repo_manager: PythonRepoManager,
-    ):
+    ):  # pylint: disable=too-many-arguments
         self.directory = directory
         self.dry_run = dry_run
         self.verbose = verbose

src/codemodder/project_analysis/file_parsers/base_parser.py

@@ -1,24 +1,31 @@
+from abc import ABC, abstractmethod
+
 from pathlib import Path
 from typing import List
 from .package_store import PackageStore
 from packaging.requirements import Requirement
 
 
-class BaseParser:
+class BaseParser(ABC):
     def __init__(self, parent_directory: Path):
         self.parent_directory = parent_directory
-        self.file_name: str = ""
 
-    def _parse_dependencies(self, lines: List[str]):
+    @property
+    @abstractmethod
+    def file_name(self):
+        ...
+
+    def _parse_dependencies(self, dependencies: List[str]):
         return [
             Requirement(line)
-            for x in lines
+            for x in dependencies
             # Skip empty lines and comments
             if (line := x.strip()) and not line.startswith("#")
         ]
 
+    @abstractmethod
     def _parse_file(self, file: Path):
-        raise NotImplementedError
+        ...
 
     def find_file_locations(self) -> List[Path]:
         return list(Path(self.parent_directory).rglob(self.file_name))

src/codemodder/project_analysis/file_parsers/pyproject_toml_file_parser.py

@@ -6,9 +6,9 @@
 
 
 class PyprojectTomlParser(BaseParser):
-    def __init__(self, parent_directory: Path):
-        super().__init__(parent_directory)
-        self.file_name = "pyproject.toml"
+    @property
+    def file_name(self):
+        return "pyproject.toml"
 
     def _parse_dependencies_from_toml(self, toml_data: dict):
         # todo: handle cases for

src/codemodder/project_analysis/file_parsers/requirements_txt_file_parser.py

@@ -1,14 +1,12 @@
 from codemodder.project_analysis.file_parsers.package_store import PackageStore
-from packaging.requirements import Requirement
 from pathlib import Path
-from typing import List
 from .base_parser import BaseParser
 
 
 class RequirementsTxtParser(BaseParser):
-    def __init__(self, parent_directory: Path):
-        super().__init__(parent_directory)
-        self.file_name = "requirements.txt"
+    @property
+    def file_name(self):
+        return "requirements.txt"
 
     def _parse_file(self, file: Path):
         with open(file, "r", encoding="utf-8") as f:

src/codemodder/project_analysis/file_parsers/setup_cfg_file_parser.py

@@ -6,9 +6,9 @@
 
 
 class SetupCfgParser(BaseParser):
-    def __init__(self, parent_directory: Path):
-        super().__init__(parent_directory)
-        self.file_name = "setup.cfg"
+    @property
+    def file_name(self):
+        return "setup.cfg"
 
     def _parse_dependencies_from_toml(self, config: configparser.ConfigParser):
         # todo: handle cases for

src/codemodder/project_analysis/file_parsers/setup_py_file_parser.py

@@ -9,14 +9,14 @@
 
 
 class SetupPyParser(BaseParser):
-    def __init__(self, parent_directory: Path):
-        super().__init__(parent_directory)
-        self.file_name = "setup.py"
+    @property
+    def file_name(self):
+        return "setup.py"
 
-    def _parse_dependencies(self, cst_dependencies):
+    def _parse_dependencies(self, dependencies):
         return [
             Requirement(line)
-            for x in cst_dependencies
+            for x in dependencies
             # Skip empty lines and comments
             if (line := clean_simplestring(x.value)) and not line.startswith("#")
         ]

tests/project_analysis/file_parsers/test_pyproject_toml_file_parser.py

@@ -1,3 +1,4 @@
+# pylint: disable=redefined-outer-name
 import pytest
 from codemodder.project_analysis.file_parsers import PyprojectTomlParser
 

tests/project_analysis/file_parsers/test_setup_cfg_file_parser.py

@@ -1,3 +1,4 @@
+# pylint: disable=redefined-outer-name
 import pytest
 from codemodder.project_analysis.file_parsers import SetupCfgParser
 

tests/project_analysis/file_parsers/test_setup_py_file_parser.py

@@ -1,3 +1,4 @@
+# pylint: disable=redefined-outer-name
 import pytest
 from codemodder.project_analysis.file_parsers import SetupPyParser