should return updated_node

pixee · Jan 12, 2024 · 36a87fe · 36a87fe
1 parent 639a42e
commit 36a87fe
Show file tree

Hide file tree

Showing 9 changed files with 15 additions and 11 deletions.
diff --git a/src/core_codemods/combine_startswith_endswith.py b/src/core_codemods/combine_startswith_endswith.py
@@ -17,7 +17,7 @@ def leave_BooleanOperation(
         if not self.filter_by_path_includes_or_excludes(
             self.node_position(original_node)
         ):
-            return original_node
+            return updated_node
 
         if self.matches_startswith_endswith_or_pattern(original_node):
             left_call = cst.ensure_type(updated_node.left, cst.Call)

diff --git a/src/core_codemods/docs/pixee_python_fix-empty-sequence-comparison.md b/src/core_codemods/docs/pixee_python_fix-empty-sequence-comparison.md
diff --git a/src/core_codemods/exception_without_raise.py b/src/core_codemods/exception_without_raise.py
@@ -30,7 +30,7 @@ def leave_SimpleStatementLine(
         if not self.filter_by_path_includes_or_excludes(
             self.node_position(original_node)
         ):
-            return original_node
+            return updated_node
 
         match original_node:
             case cst.SimpleStatementLine(

diff --git a/src/core_codemods/fix_deprecated_abstractproperty.py b/src/core_codemods/fix_deprecated_abstractproperty.py
@@ -22,7 +22,7 @@ def leave_Decorator(
         if not self.filter_by_path_includes_or_excludes(
             self.node_position(original_node)
         ):
-            return original_node
+            return updated_node
 
         if (
             base_name := self.find_base_name(original_node.decorator)

diff --git a/src/core_codemods/remove_debug_breakpoint.py b/src/core_codemods/remove_debug_breakpoint.py
@@ -12,12 +12,14 @@ class RemoveDebugBreakpoint(BaseCodemod, NameResolutionMixin, AncestorPatternsMi
     REFERENCES: list = []
 
     def leave_Expr(
-        self, original_node: cst.Expr, _
+        self,
+        original_node: cst.Expr,
+        updated_node: cst.Expr,
     ) -> Union[cst.Expr, cst.RemovalSentinel]:
         if not self.filter_by_path_includes_or_excludes(
             self.node_position(original_node)
         ):
-            return original_node
+            return updated_node
 
         match call_node := original_node.value:
             case cst.Call():
@@ -29,4 +31,4 @@ def leave_Expr(
                     self.report_change(original_node)
                     return cst.RemovalSentinel.REMOVE
 
-        return original_node
+        return updated_node
diff --git a/src/core_codemods/remove_module_global.py b/src/core_codemods/remove_module_global.py
@@ -13,12 +13,14 @@ class RemoveModuleGlobal(BaseCodemod, NameResolutionMixin):
     REFERENCES: list = []
 
     def leave_Global(
-        self, original_node: cst.Global, _
+        self,
+        original_node: cst.Global,
+        updated_node: cst.Global,
     ) -> Union[cst.Global, cst.RemovalSentinel,]:
         if not self.filter_by_path_includes_or_excludes(
             self.node_position(original_node)
         ):
-            return original_node
+            return updated_node
         scope = self.get_metadata(ScopeProvider, original_node)
         if isinstance(scope, GlobalScope):
             self.report_change(original_node)

diff --git a/src/core_codemods/remove_unnecessary_f_str.py b/src/core_codemods/remove_unnecessary_f_str.py
@@ -37,7 +37,7 @@ def _check_formatted_string(
         if not self.filter_by_path_includes_or_excludes(
             self.node_position(_original_node)
         ):
-            return _original_node
+            return updated_node
 
         transformed_node = super()._check_formatted_string(_original_node, updated_node)
         if not _original_node.deep_equals(transformed_node):

diff --git a/src/core_codemods/subprocess_shell_false.py b/src/core_codemods/subprocess_shell_false.py
@@ -33,7 +33,7 @@ def leave_Call(self, original_node: cst.Call, updated_node: cst.Call):
         if not self.filter_by_path_includes_or_excludes(
             self.node_position(original_node)
         ):
-            return original_node
+            return updated_node
 
         if self.find_base_name(original_node.func) in self.SUBPROCESS_FUNCS:
             for arg in original_node.args:

diff --git a/src/core_codemods/use_generator.py b/src/core_codemods/use_generator.py
@@ -28,7 +28,7 @@ def leave_Call(self, original_node: cst.Call, updated_node: cst.Call):
         if not self.filter_by_path_includes_or_excludes(
             self.node_position(original_node)
         ):
-            return original_node
+            return updated_node
 
         match original_node.func:
             # NOTE: could also support things like `list` and `tuple`