fix empty str comparison is a default excluded codemod

pixee · Jan 18, 2024 · 04b8586 · 04b8586
1 parent 8a535c4
commit 04b8586
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/codemodder/registry.py b/src/codemodder/registry.py
@@ -14,6 +14,8 @@
 DEFAULT_EXCLUDED_CODEMODS = [
     "pixee:python/order-imports",
     "pixee:python/unused-imports",
+    # See https://github.com/pixee/codemodder-python/pull/212 for concerns regarding this codemod.
+    "pixee:python/fix-empty-sequence-comparison",
 ]
 
 

diff --git a/src/codemodder/scripts/generate_docs.py b/src/codemodder/scripts/generate_docs.py
@@ -212,7 +212,7 @@ class DocMetadata:
     ),
     "fix-empty-sequence-comparison": DocMetadata(
         importance="Low",
-        guidance_explained="Simplifying comparison expressions to empty sequences is safe.",
+        guidance_explained="Values compared to empty sequences should be verified in case they are falsy values that are not a sequence.",
     ),
 }