Added NBallot multiplier parsing #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is most useful with parsing a tie-breaking Ballot.
|
I reviewed the Codacy results. I choose not to fix them. |
carlschroedl
commented
Jul 6, 2018
| @@ -9,6 +9,10 @@ class CandidateRankingParser | |||
| { | |||
| private const ORDERED_DELIM = ">"; | |||
| private const EQUAL_DELIM = "="; | |||
There was a problem hiding this comment.
Do you like the prohibition of these characters from text that should be parsed into a CandidateRanking or a Ballot? I'm trying to prevent someone from passing 100*A>B>C into CandidateRankingParser or BallotParser and winding up with Candidates 100*A, B,C, when what they really want is to pass the same text to NBallotParser and get candidates A, B, C voted for 100 times.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #90
This work makes it easy to concisely simulate elections, which will help implement #52 and pivot-libre/pivot#156.
Later, if/when we remove the NBallot class, the NBallot Parser can be retained. It will simply return an array of N regular Ballot instances instead of one NBallot instance.