Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Meson options for custom OpenSSL lib/hdr path #1162

Closed
wants to merge 1 commit into from

Conversation

win32asm
Copy link

Required in case the openssl library is not native to the build environment (e.g. part of vcpkg fetched dependencies).

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.10% 🎉

Comparison is base (fe5639a) 77.92% compared to head (373ca0f) 78.02%.

❗ Current head 373ca0f differs from pull request most recent head 667be05. Consider uploading reports for the commit 667be05 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1162      +/-   ##
==========================================
+ Coverage   77.92%   78.02%   +0.10%     
==========================================
  Files          53       53              
  Lines        6990     6990              
==========================================
+ Hits         5447     5454       +7     
+ Misses       1543     1536       -7     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kiplingw
Copy link
Member

Thanks @win32asm. Can you also remember to document the proposed new build flags in our README.md?

@kiplingw
Copy link
Member

I'm fine with it. @dennisjenkins75, @Tachi107?

Required in case the openssl library is not native to the build
environment (e.g. part of vcpkg fetched dependencies).
@Tachi107
Copy link
Member

I'm not a fan of this workaround. Can't you simply override the pkg-config search directories to include your custom OpenSSL build?

@win32asm
Copy link
Author

I'm not a fan of this workaround. Can't you simply override the pkg-config search directories to include your custom OpenSSL build?

Let us see if we can use a pkg-config-based detection way.

@kiplingw
Copy link
Member

I'm not a fan of this workaround. Can't you simply override the pkg-config search directories to include your custom OpenSSL build?

That's actually a really good point.

@win32asm
Copy link
Author

Thanks for the idea.

We ended up doing

PKG_CONFIG_PATH=<openssl pvt build path>/lib/pkgconfig:${PKG_CONFIG_PATH} \
meson setup build ...

@win32asm win32asm closed this Aug 30, 2023
@win32asm win32asm deleted the NonStdOpenssl branch August 30, 2023 20:15
@Tachi107
Copy link
Member

Tachi107 commented Aug 30, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants