-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Meson options for custom OpenSSL lib/hdr path #1162
Conversation
50cd63d
to
edbf2ee
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1162 +/- ##
==========================================
+ Coverage 77.92% 78.02% +0.10%
==========================================
Files 53 53
Lines 6990 6990
==========================================
+ Hits 5447 5454 +7
+ Misses 1543 1536 -7 ☔ View full report in Codecov by Sentry. |
9a2e7a3
to
7c56b68
Compare
I'm fine with it. @dennisjenkins75, @Tachi107? |
Required in case the openssl library is not native to the build environment (e.g. part of vcpkg fetched dependencies).
7c56b68
to
667be05
Compare
I'm not a fan of this workaround. Can't you simply override the pkg-config search directories to include your custom OpenSSL build? |
Let us see if we can use a pkg-config-based detection way. |
That's actually a really good point. |
Thanks for the idea. We ended up doing
|
Nice to hear! Happy to help :)
|
Required in case the openssl library is not native to the build environment (e.g. part of vcpkg fetched dependencies).