Fix __str__ method in SinglepartWriter #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice. LGTM! |
mpenkov
reviewed
Jan 10, 2024
|
@ThosRTanner Could you please enable maintainer edits for this PR? |
|
@mpenkov According to my browser, it is enabled |
|
OK, thank you! |
ddelange
added a commit
to ddelange/smart_open
that referenced
this pull request
Feb 22, 2024
…open into patch-2 * 'develop' of https://github.com/RaRe-Technologies/smart_open: fix test, for real this time update integration test Add advanced usage sections to README.rst (piskvorky#741) Add logic for handling large files in MultipartWriter uploads to s3 (piskvorky#796) Fix __str__ method in SinglepartWriter (piskvorky#791)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Fix str method in SinglepartWriter
Motivation
The bug here means that whenever you open an s3 connection and switch multipart writing off because the file is small, although the write completes successfully, you get an exception thrown when the code logs a debug message saying it has finished. This makes it look like your transfer has failed.
Tests
Added test
Checklist
Before you create the PR, please make sure you have:
Workflow
Please avoid rebasing and force-pushing to the branch of the PR once a review is in progress.
Rebasing can make your commits look a bit cleaner, but it also makes life more difficult from the reviewer, because they are no longer able to distinguish between code that has already been reviewed, and unreviewed code.