Refactor game to use context/provider #24
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mattgrunwald
force-pushed
the
mg-game-context
branch
2 times, most recently
from
e00ef7f
to
a6db0e7
Compare
mattgrunwald
force-pushed
the
mg-game-context
branch
from
a6db0e7
to
743e4c7
Compare
|
I'll merge the changes form #25 before I open this back up |
mattgrunwald
force-pushed
the
mg-game-context
branch
from
ddc98d1
to
219f349
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors our game to use context/provider, so many values are computed for us, which is nice. It also means that components can import state themselves, as opposed to having the props passed in. This makes refactoring less painful.
While this is a more "react" way of doing things, I do think it's harder to read if you aren't familiar with it.