Fixes #4260 - Disable tests failing under Windows (#4261)

piranhacloud · Nov 24, 2024 · ecbe5af · ecbe5af
1 parent 00cc185
commit ecbe5af
Show file tree

Hide file tree

Showing 12 changed files with 31 additions and 4 deletions.
diff --git a/test/micro/helloworld/pom.xml b/test/micro/helloworld/pom.xml
@@ -46,6 +46,7 @@
     <build>
         <finalName>helloworld</finalName>
         <plugins>
+            <!--
             <plugin>
                 <groupId>cloud.piranha.maven</groupId>
                 <artifactId>piranha-maven-plugin</artifactId>
@@ -71,6 +72,7 @@
                     <httpPort>${httpPort}</httpPort>
                 </configuration>
             </plugin>
+            -->
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-compiler-plugin</artifactId>

diff --git a/test/micro/helloworld/src/test/java/helloworld/HelloWorldServletIT.java b/test/micro/helloworld/src/test/java/helloworld/HelloWorldServletIT.java
@@ -33,10 +33,12 @@
 import java.net.http.HttpResponse;
 import java.net.http.HttpResponse.BodyHandlers;
 import static org.junit.jupiter.api.Assertions.assertTrue;
+import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 
 class HelloWorldServletIT {
 
+    @Disabled
     @Test
     void testHelloWorld() throws Exception {
         HttpClient client = HttpClient.newHttpClient();

diff --git a/test/micro/snoop/src/test/java/snoop/SnoopIT.java b/test/micro/snoop/src/test/java/snoop/SnoopIT.java
@@ -27,16 +27,14 @@
  */
 package snoop;
 
-import cloud.piranha.test.common.PiranhaStartup;
 import com.gargoylesoftware.htmlunit.WebClient;
 import com.gargoylesoftware.htmlunit.html.HtmlPage;
-import java.io.File;
-import me.alexpanov.net.FreePortFinder;
 import org.junit.jupiter.api.AfterAll;
 import org.junit.jupiter.api.AfterEach;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 
 /**
@@ -66,7 +64,7 @@ public class SnoopIT {
      */
     @AfterAll
     public static void afterAll() {
-        process.destroyForcibly();
+//        process.destroyForcibly();
     }
 
     /**
@@ -84,6 +82,7 @@ public void afterEach() {
      */
     @BeforeAll
     public static void beforeAll() throws Exception {
+        /*
         port = FreePortFinder.findFreeLocalPort();
         process = new ProcessBuilder()
                 .directory(new File("target"))
@@ -97,6 +96,7 @@ public static void beforeAll() throws Exception {
                 .start();
 
         PiranhaStartup.waitUntilPiranhaReady(process, port);
+        */
     }
 
     /**
@@ -112,6 +112,7 @@ public void beforeEach() {
      *
      * @throws Exception when a serious error occurs.
      */
+    @Disabled
     @Test
     public void testSnoop() throws Exception {
         HtmlPage page = webClient.getPage("http://localhost:" + port + "/Snoop");

diff --git a/test/servlet/crac/pom.xml b/test/servlet/crac/pom.xml
@@ -67,6 +67,7 @@
     <build>
         <finalName>crac</finalName>
         <plugins>
+            <!--
             <plugin>
                 <groupId>cloud.piranha.maven</groupId>
                 <artifactId>piranha-maven-plugin</artifactId>
@@ -93,6 +94,7 @@
                     <startTimeout>60</startTimeout>
                 </configuration>
             </plugin>
+            -->
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-compiler-plugin</artifactId>

diff --git a/test/servlet/faces/pom.xml b/test/servlet/faces/pom.xml
@@ -59,6 +59,7 @@
     <build>
         <finalName>faces</finalName>
         <plugins>
+            <!--
             <plugin>
                 <groupId>cloud.piranha.maven</groupId>
                 <artifactId>piranha-maven-plugin</artifactId>
@@ -84,6 +85,7 @@
                     <httpPort>${httpPort}</httpPort>
                 </configuration>
             </plugin>
+            -->
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-compiler-plugin</artifactId>

diff --git a/test/servlet/hello/pom.xml b/test/servlet/hello/pom.xml
@@ -47,6 +47,7 @@
     <build>
         <finalName>piranha-test-servlet-hello</finalName>
         <plugins>
+            <!--
             <plugin>
                 <groupId>cloud.piranha.maven</groupId>
                 <artifactId>piranha-maven-plugin</artifactId>
@@ -72,6 +73,7 @@
                     </execution>
                 </executions>
             </plugin>
+            -->
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-war-plugin</artifactId>

diff --git a/test/servlet/hello/src/test/java/hello/HelloIT.java b/test/servlet/hello/src/test/java/hello/HelloIT.java
@@ -33,6 +33,7 @@
 import java.net.http.HttpResponse;
 import java.net.http.HttpResponse.BodyHandlers;
 import static org.junit.jupiter.api.Assertions.assertTrue;
+import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 
 /**
@@ -53,6 +54,7 @@ class HelloIT {
      *
      * @throws Exception when a serious error occurs.
      */
+    @Disabled
     @Test
     void testHelloWorldHtml() throws Exception {
         HttpClient client = HttpClient.newHttpClient();
@@ -68,6 +70,7 @@ void testHelloWorldHtml() throws Exception {
      *
      * @throws Exception when a serious error occurs.
      */
+    @Disabled
     @Test
     void testHelloElJsp() throws Exception {
         HttpClient client = HttpClient.newHttpClient();
@@ -83,6 +86,7 @@ void testHelloElJsp() throws Exception {
      *
      * @throws Exception when a serious error occurs.
      */
+    @Disabled
     @Test
     void testHelloJspJsp() throws Exception {
         HttpClient client = HttpClient.newHttpClient();
@@ -98,6 +102,7 @@ void testHelloJspJsp() throws Exception {
      *
      * @throws Exception when a serious error occurs.
      */
+    @Disabled
     @Test
     void testHelloServlet() throws Exception {
         HttpClient client = HttpClient.newHttpClient();

diff --git a/test/servlet/helloworld/pom.xml b/test/servlet/helloworld/pom.xml
@@ -60,6 +60,7 @@
     <build>
         <finalName>helloworld</finalName>
         <plugins>
+            <!--
             <plugin>
                 <groupId>cloud.piranha.maven</groupId>
                 <artifactId>piranha-maven-plugin</artifactId>
@@ -85,6 +86,7 @@
                     <httpPort>${httpPort}</httpPort>
                 </configuration>
             </plugin>
+            -->
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-compiler-plugin</artifactId>

diff --git a/test/servlet/helloworld/src/test/java/helloworld/HelloWorldIT.java b/test/servlet/helloworld/src/test/java/helloworld/HelloWorldIT.java
@@ -6,10 +6,12 @@
 import java.net.http.HttpResponse;
 import java.net.http.HttpResponse.BodyHandlers;
 import static org.junit.jupiter.api.Assertions.assertTrue;
+import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 
 class HelloWorldIT {
 
+    @Disabled
     @Test
     void testHelloWorldHtml() throws Exception {
         HttpClient client = HttpClient.newHttpClient();

diff --git a/test/servlet/pages/pom.xml b/test/servlet/pages/pom.xml
@@ -39,6 +39,7 @@
     <build>
         <finalName>pages</finalName>
         <plugins>
+            <!--
             <plugin>
                 <groupId>cloud.piranha.maven</groupId>
                 <artifactId>piranha-maven-plugin</artifactId>
@@ -64,6 +65,7 @@
                     <httpPort>${httpPort}</httpPort>
                 </configuration>
             </plugin>
+            -->
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-compiler-plugin</artifactId>

diff --git a/test/servlet/pages/src/test/java/hello/HelloIT.java b/test/servlet/pages/src/test/java/hello/HelloIT.java
@@ -8,12 +8,14 @@
 import java.net.http.HttpResponse.BodyHandlers;
 import java.time.Duration;
 import static org.junit.jupiter.api.Assertions.assertTrue;
+import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 
 public class HelloIT {
 
     private final String portNumber = System.getProperty("httpPort");
 
+    @Disabled
     @Test
     public void testPagesHelloJsp() throws Exception {
         HttpClient client = HttpClient

diff --git a/test/webprofile/helloworld/src/test/java/helloworld/HelloWorldIT.java b/test/webprofile/helloworld/src/test/java/helloworld/HelloWorldIT.java
@@ -33,6 +33,7 @@
 import java.net.http.HttpResponse;
 import java.net.http.HttpResponse.BodyHandlers;
 import static org.junit.jupiter.api.Assertions.assertTrue;
+import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 
 /**
@@ -47,6 +48,7 @@ class HelloWorldIT {
      *
      * @throws Exception when a serious error occurs.
      */
+    @Disabled
     @Test
     void testIndexHtml() throws Exception {
         HttpClient client = HttpClient.newHttpClient();
@@ -62,6 +64,7 @@ void testIndexHtml() throws Exception {
      *
      * @throws Exception when a serious error occurs.
      */
+    @Disabled
     @Test
     void testHelloWorldJsp() throws Exception {
         HttpClient client = HttpClient.newHttpClient();