feat(x/evmengine): process current block events during finalizeblock after forkchoice updated #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdubpark
requested review from
LeoHChen,
AndyBoWu,
edisonz0718,
ezreal1997,
limengformal and
leeren
as code owners
Comment on lines
-542
to
-544
| // require.Len(t, executionPayload.PrevPayloadEvents, 1) | ||
| // evmLog := executionPayload.PrevPayloadEvents[0] | ||
| // require.Equal(t, evmLog.Address, zeroAddr.Bytes()) |
There was a problem hiding this comment.
Are they not needed anymore?
| if err := s.ProcessUbiEvents(ctx, payload.Number-1, msg.PrevPayloadEvents); err != nil { | ||
| return nil, errors.Wrap(err, "deliver ubi-related event logs") | ||
|
|
||
| if err := s.deliverEvents(ctx, payload.Number, events); err != nil { |
There was a problem hiding this comment.
If we change from processing payload.Number instead of payload.Number - 1 (i assume it is block height), will there be one block of data missing during upgrade?
There was a problem hiding this comment.
Yes, the linked issue specifies:
Note that on the network upgrade height itself, we should process both legacy previous block events as well as current block events. Otherwise we will miss events for upgrade height-1.
| }, | ||
| //{ |
There was a problem hiding this comment.
I assume these commented out tests will be reenabled in the future PRs?
0xHansLee
reviewed
Oct 30, 2024
| @@ -20,7 +20,6 @@ message MsgExecutionPayload { | |||
| option (cosmos.msg.v1.signer) = "authority"; | |||
| string authority = 1; | |||
| bytes execution_payload = 2; | |||
| repeated EVMEvent prev_payload_events = 3; | |||
There was a problem hiding this comment.
This field should be reserved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses omni-network/omni/issues/2106; event ordering is deterministic on the same payload received via p2p.
issue: none