Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Daily]: add screenVideo subscription for daily transport service #726

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ngamolsky
Copy link
Collaborator

Please describe the changes in your PR. If it is addressing an issue, please reference that as well.

Adds support for screen video sharing in daily transport service as we used in the anthropic hackathon a few weeks back. Let me know if more clarity is needed!

await self.update_subscriptions(
participant_settings={participant_id: {"media": {"camera": "subscribed"}}}
participant_settings={
participant_id: {"media": {"camera": "subscribed", "screenVideo": "subscribed"}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I believe this should be:

participant_settings={participant_id: {"media": {video_source: "subscribed"}}}

The settings from a previous call with a different video source will remain (e.g. if you first use camera and later use screenVideo). This way we only subscribe to what we need to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants