Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update github.com/kbinani/screenshot digest to a8a2c5d #578

Merged
merged 7 commits into from
Oct 23, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 12, 2024

This PR contains the following updates:

Package Type Update Change
github.com/kbinani/screenshot require digest b87d318 -> a8a2c5d

Configuration

📅 Schedule: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.67%. Comparing base (f2a550d) to head (8d91eda).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #578   +/-   ##
=======================================
  Coverage   44.67%   44.67%           
=======================================
  Files          80       80           
  Lines        5498     5498           
=======================================
  Hits         2456     2456           
  Misses       2875     2875           
  Partials      167      167           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renovate renovate bot changed the title fix(deps): update github.com/kbinani/screenshot digest to e520a41 fix(deps): update github.com/kbinani/screenshot digest to 30c18db Aug 19, 2024
@renovate renovate bot force-pushed the renovate/github.com-kbinani-screenshot-digest branch from 585634e to 72a5bef Compare August 19, 2024 16:51
@renovate renovate bot changed the title fix(deps): update github.com/kbinani/screenshot digest to 30c18db fix(deps): update github.com/kbinani/screenshot digest to a8a2c5d Aug 20, 2024
@renovate renovate bot force-pushed the renovate/github.com-kbinani-screenshot-digest branch from 72a5bef to 4050817 Compare August 20, 2024 17:08
Copy link
Contributor Author

renovate bot commented Aug 20, 2024

ℹ Artifact update notice

File name: go.mod

In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

  • 3 additional dependencies were updated
  • The go directive was updated for compatibility reasons

Details:

Package Change
go 1.19 -> 1.23.2
github.com/gen2brain/shm v0.0.0-20230802011745-f2460f5984f7 -> v0.1.0
github.com/jezek/xgb v1.1.0 -> v1.1.1
golang.org/x/sys v0.18.0 -> v0.24.0

@renovate renovate bot force-pushed the renovate/github.com-kbinani-screenshot-digest branch from 4050817 to 3a00446 Compare September 11, 2024 15:49
@renovate renovate bot force-pushed the renovate/github.com-kbinani-screenshot-digest branch from 3a00446 to b0e33ce Compare October 22, 2024 07:37
@at-wat
Copy link
Member

at-wat commented Oct 22, 2024

kbinani/screenshot requires Go 1.21 now

Copy link
Contributor Author

renovate bot commented Oct 22, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@at-wat
Copy link
Member

at-wat commented Oct 22, 2024

# github.com/kbinani/screenshot
Error: ../../../../go/pkg/mod/github.com/kbinani/[email protected]/darwin.go:41:14: error: use of undeclared identifier 'SCScreenshotManager'
            [SCScreenshotManager captureImageWithFilter:filter
             ^
1 error generated.
make: *** [test] Error 1

Latest kbinani/screenshot seems using SCScreenshotManager and it's supported since macOS 14.0.
The self-hosted runner seems using macOS 12 and already EOL-ed on Sep 2024.

/Users/admin/actions-runner/_work/mediadevices/mediadevices/homebrew/bin/brew
Warning: You are using macOS 12.
We (and Apple) do not provide support for this old version.

@edaniels does the machine support newer macOS? And do you think we need to support older macOS?

@edaniels
Copy link
Member

# github.com/kbinani/screenshot
Error: ../../../../go/pkg/mod/github.com/kbinani/[email protected]/darwin.go:41:14: error: use of undeclared identifier 'SCScreenshotManager'
            [SCScreenshotManager captureImageWithFilter:filter
             ^
1 error generated.
make: *** [test] Error 1

Latest kbinani/screenshot seems using SCScreenshotManager and it's supported since macOS 14.0. The self-hosted runner seems using macOS 12 and already EOL-ed on Sep 2024.

/Users/admin/actions-runner/_work/mediadevices/mediadevices/homebrew/bin/brew
Warning: You are using macOS 12.
We (and Apple) do not provide support for this old version.

@edaniels does the machine support newer macOS? And do you think we need to support older macOS?

@Otterverse would you be able to update that machine? @at-wat I no longer have access to that machine, sorry!

@edaniels
Copy link
Member

And I think we can just support the latest Mac version at this point

@at-wat
Copy link
Member

at-wat commented Oct 22, 2024

https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/
M1 macOS runner seems be available for OSS. I'm gonna try this

@at-wat
Copy link
Member

at-wat commented Oct 22, 2024

@edaniels
Copy link
Member

Oh great!

@at-wat at-wat merged commit 5ac53a4 into master Oct 23, 2024
8 checks passed
@at-wat at-wat deleted the renovate/github.com-kbinani-screenshot-digest branch October 23, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants