Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tralinig newlines from logs #288

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Remove tralinig newlines from logs #288

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions pkg/stats/stats_recorder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,25 +161,25 @@
switch rtcpPkt := pkt.(type) {
case *rtcp.FullIntraRequest:
if !contains(pkt.DestinationSSRC(), r.ssrc) {
r.logger.Debugf("skipping outgoing RTCP pkt: %v\n", pkt)
r.logger.Debugf("skipping outgoing RTCP pkt: %v", pkt)
continue
}
latestStats.InboundRTPStreamStats.FIRCount++
case *rtcp.PictureLossIndication:
if !contains(pkt.DestinationSSRC(), r.ssrc) {
r.logger.Debugf("skipping outgoing RTCP pkt: %v\n", pkt)
r.logger.Debugf("skipping outgoing RTCP pkt: %v", pkt)
continue
}
latestStats.InboundRTPStreamStats.PLICount++
case *rtcp.TransportLayerNack:
if !contains(pkt.DestinationSSRC(), r.ssrc) {
r.logger.Debugf("skipping outgoing RTCP pkt: %v\n", pkt)
r.logger.Debugf("skipping outgoing RTCP pkt: %v", pkt)

Check warning on line 176 in pkg/stats/stats_recorder.go

View check run for this annotation

Codecov / codecov/patch

pkg/stats/stats_recorder.go#L176 

Added line #L176 was not covered by tests
continue
}
latestStats.InboundRTPStreamStats.NACKCount++
case *rtcp.SenderReport:
if !contains(pkt.DestinationSSRC(), r.ssrc) {
r.logger.Debugf("skipping outgoing RTCP pkt: %v\n", pkt)
r.logger.Debugf("skipping outgoing RTCP pkt: %v", pkt)

Check warning on line 182 in pkg/stats/stats_recorder.go

View check run for this annotation

Codecov / codecov/patch

pkg/stats/stats_recorder.go#L182 

Added line #L182 was not covered by tests
continue
}
latestStats.lastSenderReports = append(latestStats.lastSenderReports, rtcpPkt.NTPTime)
Expand Down Expand Up @@ -276,7 +276,7 @@
func (r *recorder) recordIncomingRTCP(latestStats internalStats, v *incomingRTCP) internalStats {
for _, pkt := range v.pkts {
if !contains(pkt.DestinationSSRC(), r.ssrc) {
r.logger.Debugf("skipping incoming RTCP pkt: %v\n", pkt)
r.logger.Debugf("skipping incoming RTCP pkt: %v", pkt)
continue
}
switch pkt := pkt.(type) {
Expand Down
Loading