Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve jitterbuffer performance and de-duplicate code #279

Closed
wants to merge 4 commits into from

Conversation

Sean-Der
Copy link
Member

This PR removes the PriorityQueue and instead uses the rtpbuffer that was originally used by NACKs.

If user of Mutex needs thread safety they can protect. Most users of
JitterBuffer don't need it and this has a significant performance
impact.
Can be used by NACK and JitterBuffer now
@Sean-Der Sean-Der force-pushed the improve-jitterbuffer-performance branch from 39cc51e to d43229b Compare October 10, 2024 04:54
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 50 lines in your changes missing coverage. Please review.

Project coverage is 68.94%. Comparing base (0eab188) to head (60a8329).

Files with missing lines Patch % Lines
internal/rtpbuffer/rtpbuffer.go 58.20% 22 Missing and 6 partials ⚠️
internal/rtpbuffer/retainable_packet.go 61.29% 10 Missing and 2 partials ⚠️
pkg/jitterbuffer/jitter_buffer.go 85.71% 2 Missing and 2 partials ⚠️
internal/rtpbuffer/packet_factory.go 62.50% 3 Missing ⚠️
pkg/jitterbuffer/receiver_interceptor.go 50.00% 2 Missing ⚠️
pkg/nack/receive_log.go 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #279      +/-   ##
==========================================
- Coverage   72.98%   68.94%   -4.04%     
==========================================
  Files          79       79              
  Lines        3679     3571     -108     
==========================================
- Hits         2685     2462     -223     
- Misses        863      966     +103     
- Partials      131      143      +12     
Flag Coverage Δ
go ?
wasm 68.94% <66.66%> (-2.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sean-Der Sean-Der force-pushed the improve-jitterbuffer-performance branch from d43229b to 60a8329 Compare October 10, 2024 05:05
@Sean-Der Sean-Der closed this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant