Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer packet ordering until building RTCP packet #202

Merged
merged 1 commit into from
Aug 30, 2023

Commits on Aug 29, 2023

  1. Defer packet ordering until building RTCP packet

    The previous implementation did a sorted insert (O(m)) on
    every call to `Record`. If sorting is deferred until a
    feedback packet is built, we can record in constant time
    and build a packet in O(nlogn). Ordering isn't required
    until building the packet anyway, and deferring nets a minor
    performance gain (I say minor since its unlikely there are a
    large number of received packets in the buffer prior to
    building a feedback packet). If ordering is really needed on
    record, we could use something like a B-tree to get O(logn)
    sorted inserts.
    treyhakanson committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    a646d66 View commit details
    Browse the repository at this point in the history