Add an initial, very simple, jitter buffer #671
thatsnotrightlint.yaml
on: pull_request
lint
/
Metadata
19s
lint
/
Go
27s
Annotations
2 errors and 12 warnings
|
Invalid Go version:
go.mod#L3
Found 1.15. Expected 1.19
|
|
lint / Go
issues found
|
|
lint / Metadata
Restore cache failed: Dependencies file is not found in /home/runner/work/interceptor/interceptor. Supported file pattern: go.sum
|
|
lint / Go
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: golangci/golangci-lint-action@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
lint / Go:
pkg/jitterbuffer/jitter_buffer.go#L22
error-naming: error var BufferUnderrun should have name of the form ErrFoo (revive)
|
|
lint / Go:
pkg/jitterbuffer/jitter_buffer.go#L23
error-naming: error var PopWhileBuffering should have name of the form ErrFoo (revive)
|
|
lint / Go:
pkg/jitterbuffer/jitter_buffer.go#L1
package-comments: package comment should be of the form "Package jitterbuffer ..." (revive)
|
|
lint / Go:
pkg/jitterbuffer/priority_queue.go#L25
error-naming: error var InvalidOperation should have name of the form ErrFoo (revive)
|
|
lint / Go:
pkg/jitterbuffer/priority_queue.go#L26
error-naming: error var NotFound should have name of the form ErrFoo (revive)
|
|
lint / Go:
pkg/jitterbuffer/jitter_buffer.go#L56
var-naming: don't use underscores in Go names; struct field last_sequence should be lastSequence (revive)
|
|
lint / Go:
pkg/jitterbuffer/jitter_buffer.go#L57
var-naming: don't use underscores in Go names; struct field playout_head should be playoutHead (revive)
|
|
lint / Go:
pkg/jitterbuffer/priority_queue.go#L12
exported: exported type PriorityQueue should have comment or be unexported (revive)
|
|
lint / Go:
pkg/jitterbuffer/jitter_buffer.go#L58
var-naming: don't use underscores in Go names; struct field playout_ready should be playoutReady (revive)
|
|
lint / Go:
pkg/jitterbuffer/jitter_buffer.go#L60
var-naming: don't use underscores in Go names; struct field sample_rate should be sampleRate (revive)
|