Skip to content

Remove already-implemented TODO comments #18

Remove already-implemented TODO comments

Remove already-implemented TODO comments #18

Triggered via push January 25, 2024 22:06
Status Failure
Total duration 18m 20s
Artifacts

ci.yml

on: push
Matrix: linters
Matrix: tests-docker
Matrix: tests
Fit to window
Zoom out
Zoom in

Annotations

51 errors and 39 warnings
linters (misc): doc/treetabs.md#L41
Found "behaviour" - Common misspelling or non-US spelling
linters (misc): doc/treetabs.md#L93
Found "behaviour" - Common misspelling or non-US spelling
linters (misc): doc/treetabs.md#L158
Found "behaviour" - Common misspelling or non-US spelling
linters (misc)
Process completed with exit code 1.
linters (flake8)
Process completed with exit code 1.
linters (vulture)
Process completed with exit code 1.
linters (mypy-pyqt5)
Process completed with exit code 1.
linters (mypy-pyqt6)
Process completed with exit code 1.
linters (pylint)
Process completed with exit code 28.
tests (py312-pyqt66, macos-12, 3.12, tests/unit)
FAILED tests/unit/mainwindow/test_tabwidget.py::TestTabWidget::test_small_icon_doesnt_crash - Failed: CALL ERROR: Exceptions caught in Qt event loop:
tests (py312-pyqt66, macos-12, 3.12, tests/unit)
Process completed with exit code 1.
tests (py312-pyqt66, macos-11, 3.12, tests/unit)
FAILED tests/unit/mainwindow/test_tabwidget.py::TestTabWidget::test_small_icon_doesnt_crash - Failed: CALL ERROR: Exceptions caught in Qt event loop:
tests (py312-pyqt66, macos-11, 3.12, tests/unit)
Process completed with exit code 1.
tests-docker (py-qt5, archlinux-webkit)
FAILED tests/unit/mainwindow/test_tabwidget.py::TestTabWidget::test_small_icon_doesnt_crash - Failed: CALL ERROR: Exceptions caught in Qt event loop:
tests-docker (py-qt5, archlinux-webkit)
Process completed with exit code 1.
tests-docker (py, archlinux-webengine-qt6)
FAILED tests/unit/mainwindow/test_tabwidget.py::TestTabWidget::test_small_icon_doesnt_crash - Failed: CALL ERROR: Exceptions caught in Qt event loop:
tests-docker (py, archlinux-webengine-qt6)
Process completed with exit code 1.
tests (py311-pyqt66, ubuntu-22.04, 3.11)
FAILED tests/end2end/test_insert_mode.py::test_auto_load[True-False-True] - end2end.fixtures.testprocess.WaitForTimeout: Timed out after 15000ms waiting for {'message': 'Entering mode KeyMode.insert (reason: *)'}.
tests (py311-pyqt66, ubuntu-22.04, 3.11)
FAILED tests/unit/mainwindow/test_tabwidget.py::TestTabWidget::test_small_icon_doesnt_crash - Failed: CALL ERROR: Exceptions caught in Qt event loop:
tests (py311-pyqt66, ubuntu-22.04, 3.11)
Process completed with exit code 1.
tests (py311-pyqt515, ubuntu-20.04, 3.11)
FAILED tests/unit/mainwindow/test_tabwidget.py::TestTabWidget::test_small_icon_doesnt_crash - Failed: CALL ERROR: Exceptions caught in Qt event loop:
tests (py311-pyqt515, ubuntu-20.04, 3.11)
Process completed with exit code 1.
tests-docker (py-qt5, archlinux-webengine)
FAILED tests/unit/mainwindow/test_tabwidget.py::TestTabWidget::test_small_icon_doesnt_crash - Failed: CALL ERROR: Exceptions caught in Qt event loop:
tests-docker (py-qt5, archlinux-webengine)
Process completed with exit code 1.
tests-docker (py, archlinux-webengine-unstable-qt6)
FAILED tests/end2end/test_insert_mode.py::test_auto_load[True-False-True] - end2end.fixtures.testprocess.WaitForTimeout: Timed out after 15000ms waiting for {'message': 'Entering mode KeyMode.insert (reason: *)'}.
tests-docker (py, archlinux-webengine-unstable-qt6)
FAILED tests/unit/mainwindow/test_tabwidget.py::TestTabWidget::test_small_icon_doesnt_crash - Failed: CALL ERROR: Exceptions caught in Qt event loop:
tests-docker (py, archlinux-webengine-unstable-qt6)
Process completed with exit code 1.
tests-docker (py-qt5, archlinux-webengine-unstable)
FAILED tests/unit/mainwindow/test_tabwidget.py::TestTabWidget::test_small_icon_doesnt_crash - Failed: CALL ERROR: Exceptions caught in Qt event loop:
tests-docker (py-qt5, archlinux-webengine-unstable)
Process completed with exit code 1.
tests (py310-pyqt65, ubuntu-22.04, 3.10)
FAILED tests/end2end/test_insert_mode.py::test_auto_load[True-False-True] - end2end.fixtures.testprocess.WaitForTimeout: Timed out after 15000ms waiting for {'message': 'Entering mode KeyMode.insert (reason: *)'}.
tests (py310-pyqt65, ubuntu-22.04, 3.10)
FAILED tests/unit/mainwindow/test_tabwidget.py::TestTabWidget::test_small_icon_doesnt_crash - Failed: CALL ERROR: Exceptions caught in Qt event loop:
tests (py310-pyqt65, ubuntu-22.04, 3.10)
Process completed with exit code 1.
tests (py37-pyqt5152, ubuntu-20.04, 3.8)
FAILED tests/unit/mainwindow/test_tabwidget.py::TestTabWidget::test_small_icon_doesnt_crash - Failed: CALL ERROR: Exceptions caught in Qt event loop:
tests (py37-pyqt5152, ubuntu-20.04, 3.8)
Process completed with exit code 1.
tests (py37-pyqt62, ubuntu-20.04, 3.8)
FAILED tests/unit/mainwindow/test_tabwidget.py::TestTabWidget::test_small_icon_doesnt_crash - Failed: CALL ERROR: Exceptions caught in Qt event loop:
tests (py37-pyqt62, ubuntu-20.04, 3.8)
Process completed with exit code 1.
tests (py38-pyqt63, ubuntu-20.04, 3.8)
FAILED tests/end2end/test_insert_mode.py::test_auto_load[True-False-True] - end2end.fixtures.testprocess.WaitForTimeout: Timed out after 15000ms waiting for {'message': 'Entering mode KeyMode.insert (reason: *)'}.
tests (py38-pyqt63, ubuntu-20.04, 3.8)
FAILED tests/unit/mainwindow/test_tabwidget.py::TestTabWidget::test_small_icon_doesnt_crash - Failed: CALL ERROR: Exceptions caught in Qt event loop:
tests (py38-pyqt63, ubuntu-20.04, 3.8)
Process completed with exit code 1.
tests (py312-pyqt66, ubuntu-22.04, 3.12)
FAILED tests/end2end/test_insert_mode.py::test_auto_load[True-False-True] - end2end.fixtures.testprocess.WaitForTimeout: Timed out after 15000ms waiting for {'message': 'Entering mode KeyMode.insert (reason: *)'}.
tests (py312-pyqt66, ubuntu-22.04, 3.12)
FAILED tests/unit/mainwindow/test_tabwidget.py::TestTabWidget::test_small_icon_doesnt_crash - Failed: CALL ERROR: Exceptions caught in Qt event loop:
tests (py312-pyqt66, ubuntu-22.04, 3.12)
Process completed with exit code 1.
tests (py39-pyqt64, ubuntu-20.04, 3.9)
FAILED tests/unit/mainwindow/test_tabwidget.py::TestTabWidget::test_small_icon_doesnt_crash - Failed: CALL ERROR: Exceptions caught in Qt event loop:
tests (py39-pyqt64, ubuntu-20.04, 3.9)
Process completed with exit code 1.
tests (py312-pyqt66, windows-2019, 3.12)
end2end.fixtures.testprocess.WaitForTimeout: Timed out after 15000ms waiting for {'category': 'message', 'loglevel': 20, 'message': '7 chars yanked to clipboard'}.
tests (py312-pyqt66, windows-2019, 3.12)
Failed: Failed to get selection!
tests (py312-pyqt66, windows-2019, 3.12)
FAILED tests/end2end/test_insert_mode.py::test_auto_load[True-False-True] - end2end.fixtures.testprocess.WaitForTimeout: Timed out after 15000ms waiting for {'message': 'Entering mode KeyMode.insert (reason: *)'}.
tests (py312-pyqt66, windows-2019, 3.12)
FAILED tests/end2end/features/test_caret_bdd.py::test_yank_selection_with_keep - end2end.fixtures.testprocess.WaitForTimeout: Timed out after 15000ms waiting for {'category': 'message', 'loglevel': 20, 'message': '7 chars yanked to clipboard'}.
tests (py312-pyqt66, windows-2019, 3.12)
FAILED tests/unit/browser/test_caret.py::TestWord::test_moving_to_end_and_selecting_a_word[webengine] - Failed: Failed to get selection!
tests (py312-pyqt66, windows-2019, 3.12)
FAILED tests/unit/mainwindow/test_tabwidget.py::TestTabWidget::test_small_icon_doesnt_crash - Failed: CALL ERROR: Exceptions caught in Qt event loop:
tests (py312-pyqt66, windows-2019, 3.12)
Process completed with exit code 1.
linters (shellcheck, -f gcc)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
linters (misc)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
linters (pyroma)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
linters (actionlint)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
linters (yamllint)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
linters (check-manifest)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
linters (eslint)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
linters (package)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
linters (flake8)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
linters (flake8): qutebrowser/browser/commands.py#L499
local variable 'oldroot' is assigned to but never used
linters (flake8): qutebrowser/mainwindow/treetabbedbrowser.py#L83
No blank lines allowed after function docstring
linters (flake8): qutebrowser/mainwindow/treetabwidget.py#L77
Unnecessary list comprehension passed to all() prevents short-circuiting - rewrite as a generator.
linters (docs)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
linters (vulture)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
linters (vulture): qutebrowser/browser/commands.py#L499
unused variable 'oldroot' (60% confidence)
linters (mypy-pyqt5)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
linters (mypy-pyqt6)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
linters (pylint)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
linters (pylint): qutebrowser/misc/notree.py#L60
Class constant name "PRE" doesn't conform to snake_case naming style
linters (pylint): qutebrowser/misc/notree.py#L61
Class constant name "POST" doesn't conform to snake_case naming style
linters (pylint): qutebrowser/misc/notree.py#L62
Class constant name "POST_R" doesn't conform to snake_case naming style
linters (pylint): qutebrowser/misc/notree.py#L221
Consider using "elif" instead of "else" then "if" to remove one indentation level
linters (pylint): qutebrowser/misc/notree.py#L289
Raising too general exception: Exception
linters (pylint): qutebrowser/misc/notree.py#L256
Unused private member `Node.__add_child(self, node: 'Node[T]')`
linters (pylint): qutebrowser/misc/notree.py#L260
Unused private member `Node.__disown(self, value: 'Node[T]')`
linters (pylint): qutebrowser/misc/notree.py#L190
Unused private member `Node.__modified`
linters (pylint): qutebrowser/misc/notree.py#L68
Useless suppression of 'invalid-name'
linters (pylint): qutebrowser/browser/commands.py#L499
Unused variable 'oldroot'
tests (py312-pyqt66, macos-12, 3.12, tests/unit)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
tests (py312-pyqt66, macos-11, 3.12, tests/unit)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
tests (py311-pyqt66, ubuntu-22.04, 3.11)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
tests (py311-pyqt515, ubuntu-20.04, 3.11)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
tests (py310-pyqt65, ubuntu-22.04, 3.10)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
tests (py37-pyqt5152, ubuntu-20.04, 3.8)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
tests (py37-pyqt62, ubuntu-20.04, 3.8)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
tests (py38-pyqt63, ubuntu-20.04, 3.8)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
tests (py312-pyqt66, ubuntu-22.04, 3.12)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
tests (py39-pyqt64, ubuntu-20.04, 3.9)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
tests (py312-pyqt66, windows-2019, 3.12)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.