Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sink(ticdc): add event key output for debezium (#11649) #11965

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #11649

What problem does this PR solve?

Issue Number: close #11652

What is changed and how it works?

Debezium send event key and event value to kafka. I added event key output to this PR.
Also modify function SanitizeName for keeping same with official code.

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Fix the issue that the Key of Kafka messages has't been filled in Debezium protocol.

@ti-chi-bot ti-chi-bot added lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Jan 2, 2025
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 26.92308% with 209 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.1@6cd1c19). Learn more about missing BASE report.

Additional details and impacted files
Components Coverage Δ
cdc 61.6084% <0.0000%> (?)
dm 51.0953% <0.0000%> (?)
engine 63.4444% <0.0000%> (?)
Flag Coverage Δ
unit 57.3495% <26.9230%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             release-8.1     #11965   +/-   ##
================================================
  Coverage               ?   57.3495%           
================================================
  Files                  ?        854           
  Lines                  ?     126320           
  Branches               ?          0           
================================================
  Hits                   ?      72444           
  Misses                 ?      48454           
  Partials               ?       5422           

Copy link
Contributor

ti-chi-bot bot commented Jan 6, 2025

@ti-chi-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
jenkins-ticdc/verify 4691d09 link true /test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@wk989898
Copy link
Collaborator

wk989898 commented Jan 6, 2025

/retest

Copy link
Contributor

ti-chi-bot bot commented Jan 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wk989898

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jan 6, 2025
@ti-chi-bot ti-chi-bot bot merged commit 3e1dad2 into pingcap:release-8.1 Jan 6, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants