-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
redo(ticdc): Fix RedoLogWriter unit test (#11853) #11937
redo(ticdc): Fix RedoLogWriter unit test (#11853) #11937
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wk989898 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## release-8.1 #11937 +/- ##
================================================
Coverage ? 57.4189%
================================================
Files ? 854
Lines ? 126089
Branches ? 0
================================================
Hits ? 72399
Misses ? 48289
Partials ? 5401 |
This is an automated cherry-pick of #11853
What problem does this PR solve?
Issue Number: close #11852
What is changed and how it works?
A select blocks until one of its cases can run, then it executes that case. It chooses one at random if multiple are ready.
In these cases, encodingWorkerGroup may run
WriteEvents
orFlushLog
successfully even if encoding worker is closed.Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note