Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: prompt k8s.io/api version (#11866) #11900

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #11866

What problem does this PR solve?

Issue Number: close #11865

k8s.io/api has risks of some security issue at current v0.28.x version.

What is changed and how it works?

Prompt the version to v0.29.11.

Check List

Tests

  • No code

Questions

Will it cause performance regression or break compatibility?

No.

Do you need to update user documentation, design documentation or monitoring documentation?

No.

Release note

Prompt k8s.io/api library to 0.29.11 to mitigate possible security risks.

@ti-chi-bot ti-chi-bot added area/dm Issues or PRs related to DM. area/ticdc Issues or PRs related to TiCDC. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Dec 17, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CharlesCheung96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Dec 18, 2024
@wlwilliamx
Copy link
Contributor

/retest

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-8.1@0c88977). Learn more about missing BASE report.

Additional details and impacted files
Components Coverage Δ
cdc 61.8216% <0.0000%> (?)
dm 51.0246% <0.0000%> (?)
engine 63.4091% <0.0000%> (?)
Flag Coverage Δ
unit 57.4134% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             release-8.1     #11900   +/-   ##
================================================
  Coverage               ?   57.4134%           
================================================
  Files                  ?        854           
  Lines                  ?     126089           
  Branches               ?          0           
================================================
  Hits                   ?      72392           
  Misses                 ?      48294           
  Partials               ?       5403           

@wlwilliamx
Copy link
Contributor

/retest

@wlwilliamx
Copy link
Contributor

/test dm-integration-test

1 similar comment
@wlwilliamx
Copy link
Contributor

/test dm-integration-test

@wlwilliamx
Copy link
Contributor

/retest

@wlwilliamx
Copy link
Contributor

wlwilliamx commented Dec 18, 2024

/hold, wait for pingcap/tidb#58389, close #11906.

@wlwilliamx
Copy link
Contributor

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2024
@wlwilliamx
Copy link
Contributor

/test cdc-integration-mysql-test

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved and removed cherry-pick-approved Cherry pick PR approved by release team. labels Dec 19, 2024
@wlwilliamx
Copy link
Contributor

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 19, 2024
@wlwilliamx
Copy link
Contributor

/test dm-integration-test

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Dec 19, 2024
@wlwilliamx
Copy link
Contributor

/test dm-integration-test

@ti-chi-bot ti-chi-bot bot merged commit cd5e9e4 into pingcap:release-8.1 Dec 19, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dm Issues or PRs related to DM. area/ticdc Issues or PRs related to TiCDC. cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants