consumer(ticdc): canal-json decoder cache table info for each message to avoid allocate memory on each new message #11895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
release-note
…ion can receive the ddl message
|
/retest |
1 similar comment
|
/retest |
ti-chi-bot
bot
added
size/L
3AceShowHand
force-pushed
the
canal-json-consumer-memory
branch
from
13be1b6 to
74cc7ea
Compare
ti-chi-bot
bot
added
size/XL
3AceShowHand
changed the title
ti-chi-bot
bot
added
release-note-none
wk989898
reviewed
Dec 19, 2024
| } | ||
| } | ||
| indexInfo := &timodel.IndexInfo{ | ||
| ID: 1, |
There was a problem hiding this comment.
Please follow the previous behavior. https://github.com/pingcap/tiflow/blob/master/cdc/model/sink.go#L917-L920
There was a problem hiding this comment.
there is only primary key, and should 1, it's the previous behavior.
wk989898
approved these changes
Dec 19, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
3AceShowHand
commented
Dec 19, 2024
| @@ -48,6 +56,8 @@ type batchDecoder struct { | |||
|
|
|||
| upstreamTiDB *sql.DB | |||
| bytesDecoder *encoding.Decoder | |||
|
|
|||
| tableInfoCache map[tableKey]*model.TableInfo | |||
There was a problem hiding this comment.
cached item is deleted if receive table level DDL, and recreate a new table info.
lidezhu
approved these changes
Dec 19, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lidezhu, wk989898 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sage
What problem does this PR solve?
Issue Number: close #11894, close #11907
What is changed and how it works?
==Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note