-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dm: fix start task check when both shard-mode and TLS are configured (#11843) #11863
base: release-8.5
Are you sure you want to change the base?
dm: fix start task check when both shard-mode and TLS are configured (#11843) #11863
Conversation
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## release-8.5 #11863 +/- ##
================================================
Coverage ? 55.1660%
================================================
Files ? 1002
Lines ? 136575
Branches ? 0
================================================
Hits ? 75343
Misses ? 55726
Partials ? 5506 |
/retest |
3 similar comments
/retest |
/retest |
/retest |
Signed-off-by: Xiaoguang Sun <[email protected]>
Signed-off-by: Xiaoguang Sun <[email protected]>
3bdbb64
to
30c4fb8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@ti-chi-bot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This is an automated cherry-pick of #11843
What problem does this PR solve?
When task configuration contains both shard-mode and TLS configuration, start task fails
Issue Number: close #11842
What is changed and how it works?
The content of the task configuration file is replaced with the TLS context populated when TLS configuration exists. The changed configuration file content generates false positives in the pre-checking logic. Reordering the pre-checking and loading of the TLS context can make it work in such cases.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note