Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dm: fix start task check when both shard-mode and TLS are configured (#11843) #11863

Open
wants to merge 2 commits into
base: release-8.5
Choose a base branch
from

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #11843

What problem does this PR solve?

When task configuration contains both shard-mode and TLS configuration, start task fails

Image

Issue Number: close #11842

What is changed and how it works?

The content of the task configuration file is replaced with the TLS context populated when TLS configuration exists. The changed configuration file content generates false positives in the pre-checking logic. Reordering the pre-checking and loading of the TLS context can make it work in such cases.

Check List

Tests

  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@ti-chi-bot ti-chi-bot added area/dm Issues or PRs related to DM. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Dec 11, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 11, 2024

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.5@d8f0a6e). Learn more about missing BASE report.

Additional details and impacted files
Components Coverage Δ
cdc 59.6437% <0.0000%> (?)
dm 50.0577% <0.0000%> (?)
engine 53.2336% <0.0000%> (?)
Flag Coverage Δ
unit 55.1660% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             release-8.5     #11863   +/-   ##
================================================
  Coverage               ?   55.1660%           
================================================
  Files                  ?       1002           
  Lines                  ?     136575           
  Branches               ?          0           
================================================
  Hits                   ?      75343           
  Misses                 ?      55726           
  Partials               ?       5506           

@sunxiaoguang
Copy link
Contributor

/retest

3 similar comments
@sunxiaoguang
Copy link
Contributor

/retest

@sunxiaoguang
Copy link
Contributor

/retest

@sunxiaoguang
Copy link
Contributor

/retest

@Benjamin2037 Benjamin2037 added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. and removed needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Dec 16, 2024
@ti-chi-bot ti-chi-bot force-pushed the cherry-pick-11843-to-release-8.5 branch from 3bdbb64 to 30c4fb8 Compare December 16, 2024 05:52
Copy link
Contributor

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

ti-chi-bot bot commented Dec 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 16, 2024
@sunxiaoguang
Copy link
Contributor

/retest

Copy link
Contributor

ti-chi-bot bot commented Dec 16, 2024

@ti-chi-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-dm-integration-test 30c4fb8 link true /test dm-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dm Issues or PRs related to DM. do-not-merge/cherry-pick-not-approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants