-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dep(*): move code of sync_diff_inspector from tidb-tools to tiflow #11671
base: master
Are you sure you want to change the base?
Conversation
/retest |
/test verify |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #11671 +/- ##
================================================
- Coverage 55.2441% 55.1810% -0.0632%
================================================
Files 1001 1025 +24
Lines 136237 141284 +5047
================================================
+ Hits 75263 77962 +2699
- Misses 55486 57621 +2135
- Partials 5488 5701 +213 |
/retest |
1 similar comment
/retest |
[LGTM Timeline notifier]Timeline:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance6716 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
go.mod
Outdated
@@ -345,7 +346,7 @@ require ( | |||
github.com/shurcooL/httpfs v0.0.0-20230704072500-f1e31cf0ba5c // indirect | |||
github.com/shurcooL/httpgzip v0.0.0-20190720172056-320755c1c1b0 // indirect | |||
github.com/shurcooL/vfsgen v0.0.0-20200824052919-0d455de96546 // indirect | |||
github.com/siddontang/go v0.0.0-20180604090527-bdc77568d726 // indirect | |||
github.com/siddontang/go v0.0.0-20180604090527-bdc77568d726 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please move it to direct group to keep it pretty.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold merge it when v8.5.0 released. |
@joechenrh: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: close #11672
What is changed and how it works?
Since the only module in use in tidb-tools is sync_diff_inspector, which is used by DM and CDC. So we want to move this package into tiflow repo, and then we can deprecate tidb-tools repo.
Note:
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note